fix: propagate context at MCP server #1644
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
CakeCrusher
force-pushed
the
fix_mcp_ctx_propagation
branch
from
f88a4d3 to
d9068a1
Compare
CakeCrusher
force-pushed
the
fix_mcp_ctx_propagation
branch
from
d9068a1 to
e955392
Compare
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Mikyo King <mikyo@arize.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
dosubot
bot
added
size:XL
This was referenced May 20, 2025
Co-authored-by: Mikyo King <mikeldking@gmail.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
dosubot
bot
added
size:XXL
|
Have not tested multiplexing, so it may be vulnerable to that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR:
The context passed by the
InstrumentedStreamWriter.sendwas being mutated by processes preceedingInstrumentedStreamReaderresulting in disjointed MCP traces.By adding instrumentation at
_handle_request(an earlier state in the program flow) the original message composed byInstrumentedStreamWriter.sendis preserved. This context is then propagated at the server level.the context is detached by the same method it was being detached before, through
InstrumentedStreamReader.